Summary: | REGRESSION(r84112): Chromium linux layout tests are broken. (Requested by loislo2 on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, loislo, ojan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 58690 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-04-18 02:41:59 PDT
Created attachment 90008 [details] ROLLOUT of r84112 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 90008 [details] ROLLOUT of r84112 Clearing flags on attachment: 90008 Committed r84127: <http://trac.webkit.org/changeset/84127> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/84127 might have broken GTK Linux 64-bit Debug Okay, there's an actual bug here as well. Doing a read on a non-blocking socket may raise EAGAIN / EWOULDBLOCK if there is no data available, and we weren't catching that case. I'm not sure why I didn't see this when I tested this the first time, since it's a pretty pervasive failure. It's easy to patch this, but I wonder what the performance cost will be of catching errors vs. doing a select first to see if data is available, since raising an error is the common case. |