Bug 58764

Summary:

Web Inspector: Backspace in the Console is broken

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

58875

Bug Blocks:

Attachments:

Description	Flags
[PATCH] Suggested fix	yurys: review-
[PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements	yurys: review+

Alexander Pavlov (apavlov)

Reported 2011-04-18 00:12:55 PDT

This is a regression from http://trac.webkit.org/changeset/83968

Attachments
[PATCH] Suggested fix (1.40 KB, patch) 2011-04-18 01:16 PDT, Alexander Pavlov (apavlov)	yurys: review-	Details Formatted Diff Diff
[PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements (1.63 KB, patch) 2011-04-18 09:15 PDT, Alexander Pavlov (apavlov)	yurys: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2011-04-18 01:16:43 PDT

Created attachment 90002 [details] [PATCH] Suggested fix

Yury Semikhatsky

Comment 2 2011-04-18 02:04:53 PDT

Comment on attachment 90002 [details] [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=90002&action=review > Source/WebCore/inspector/front-end/inspector.js:797 > + if (!selection.rangeCount || !selection.isCollapsed) This will break backspace on non-empty selection. r- for this.

Alexander Pavlov (apavlov)

Comment 3 2011-04-18 09:15:22 PDT

Created attachment 90043 [details] [PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements

Yury Semikhatsky

Comment 4 2011-04-18 09:17:34 PDT

Comment on attachment 90043 [details] [PATCH] A proper fix that only inhibits Backspace default handling for -webkit-user-modify: read-only elements View in context: https://bugs.webkit.org/attachment.cgi?id=90043&action=review > Source/WebCore/inspector/front-end/inspector.js:797 > + var computedStyle = document.defaultView.getComputedStyle(this.currentFocusElement, null, ""); Could you provide a comment explaining this logic?

Alexander Pavlov (apavlov)

Comment 5 2011-04-18 09:24:31 PDT

Committed r84150: <http://trac.webkit.org/changeset/84150>

WebKit Review Bot

Comment 6 2011-04-18 12:20:45 PDT

http://trac.webkit.org/changeset/84150 might have broken GTK Linux 32-bit Debug

Alexander Pavlov (apavlov)

Comment 7 2011-04-19 03:01:05 PDT

Rolled out in r84236.

Note You need to log in before you can comment on or make changes to this bug.