Bug 58718

Summary: Remove DeprecatedPtr
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, ossy, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 58720, 58724, 58871    
Bug Blocks:    
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2011-04-15 17:58:11 PDT
Remove DeprecatedPtr
Attachments
Patch (4.61 KB, patch)
2011-04-15 17:58 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-04-15 17:58:40 PDT
Created attachment 89895 [details] Patch
Gavin Barraclough
Comment 2 2011-04-15 18:03:39 PDT
Comment on attachment 89895 [details] Patch "Remove DeprecatedPtr". This should read "Deprecate DeprecatedPtr". :-(
Oliver Hunt
Comment 3 2011-04-15 18:13:13 PDT
Committed r84067: <http://trac.webkit.org/changeset/84067>
WebKit Review Bot
Comment 4 2011-04-15 18:22:59 PDT
http://trac.webkit.org/changeset/84067 might have broken Qt Linux Release minimal, Qt Linux ARMv7 Release, and Qt Windows 32-bit Release
Daniel Bates
Comment 5 2011-04-15 22:46:16 PDT
This patch was rolled out in changeset 84081 <http://trac.webkit.org/changeset/84081> (bug #58724).
Daniel Bates
Comment 6 2011-04-15 22:47:40 PDT
Reopening this bug since the patch was rolled out because it broke the Qt build.
Daniel Bates
Comment 7 2011-04-15 22:52:00 PDT
For completeness, the stdio from the Qt Linux Release bot is here: <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/31501/steps/compile-webkit/logs/stdio>.
Early Warning System Bot
Comment 8 2011-04-16 02:43:33 PDT
Attachment 89895 [details] did not build on qt: Build output: http://queues.webkit.org/results/8459405
Oliver Hunt
Comment 9 2011-04-18 13:35:07 PDT
Committed r84176: <http://trac.webkit.org/changeset/84176>
WebKit Review Bot
Comment 10 2011-04-18 13:44:25 PDT
http://trac.webkit.org/changeset/84176 might have broken Qt Linux Release minimal, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, and EFL Linux Release (Build)
Csaba Osztrogonác
Comment 11 2011-04-19 07:11:55 PDT
It was rolled out, see https://bugs.webkit.org/show_bug.cgi?id=58871 for details.
Oliver Hunt
Comment 12 2011-04-19 14:12:59 PDT
Committed r84289: <http://trac.webkit.org/changeset/84289>
WebKit Review Bot
Comment 13 2011-04-19 14:21:14 PDT
http://trac.webkit.org/changeset/84289 might have broken SnowLeopard Intel Release (Build)
Note You need to log in before you can comment on or make changes to this bug.