Bug 58718 - Remove DeprecatedPtr
Summary: Remove DeprecatedPtr
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
Depends on: 58720 58724 58871
  Show dependency treegraph
Reported: 2011-04-15 17:58 PDT by Oliver Hunt
Modified: 2011-04-19 14:21 PDT (History)
6 users (show)

See Also:

Patch (4.61 KB, patch)
2011-04-15 17:58 PDT, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-04-15 17:58:11 PDT
Remove DeprecatedPtr
Comment 1 Oliver Hunt 2011-04-15 17:58:40 PDT
Created attachment 89895 [details]
Comment 2 Gavin Barraclough 2011-04-15 18:03:39 PDT
Comment on attachment 89895 [details]

"Remove DeprecatedPtr".  This should read "Deprecate DeprecatedPtr". :-(
Comment 3 Oliver Hunt 2011-04-15 18:13:13 PDT
Committed r84067: <http://trac.webkit.org/changeset/84067>
Comment 4 WebKit Review Bot 2011-04-15 18:22:59 PDT
http://trac.webkit.org/changeset/84067 might have broken Qt Linux Release minimal, Qt Linux ARMv7 Release, and Qt Windows 32-bit Release
Comment 5 Daniel Bates 2011-04-15 22:46:16 PDT
This patch was rolled out in changeset 84081 <http://trac.webkit.org/changeset/84081> (bug #58724).
Comment 6 Daniel Bates 2011-04-15 22:47:40 PDT
Reopening this bug since the patch was rolled out because it broke the Qt build.
Comment 7 Daniel Bates 2011-04-15 22:52:00 PDT
For completeness, the stdio from the Qt Linux Release bot is here: <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/31501/steps/compile-webkit/logs/stdio>.
Comment 8 Early Warning System Bot 2011-04-16 02:43:33 PDT
Attachment 89895 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8459405
Comment 9 Oliver Hunt 2011-04-18 13:35:07 PDT
Committed r84176: <http://trac.webkit.org/changeset/84176>
Comment 10 WebKit Review Bot 2011-04-18 13:44:25 PDT
http://trac.webkit.org/changeset/84176 might have broken Qt Linux Release minimal, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, and EFL Linux Release (Build)
Comment 11 Csaba Osztrogonác 2011-04-19 07:11:55 PDT
It was rolled out, see https://bugs.webkit.org/show_bug.cgi?id=58871 for details.
Comment 12 Oliver Hunt 2011-04-19 14:12:59 PDT
Committed r84289: <http://trac.webkit.org/changeset/84289>
Comment 13 WebKit Review Bot 2011-04-19 14:21:14 PDT
http://trac.webkit.org/changeset/84289 might have broken SnowLeopard Intel Release (Build)