|Product:||WebKit||Reporter:||Timothy Hatcher <timothy>|
|Severity:||Critical||CC:||abarth, dslomov, eric, levin, lforschler, mrowe, timothy, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.6|
Description Timothy Hatcher 2011-04-15 17:31:50 PDT
Comment 1 Timothy Hatcher 2011-04-15 17:34:06 PDT
The correct way to do this would be to build gtest and have JSC depend on it and link against it. Like WebCore does with ANGLE.
Comment 2 Timothy Hatcher 2011-04-15 17:40:47 PDT
Mark Rowe has told me the build still works. But this is still not the normal way we do cross project dependancy in WebKit.
Comment 3 Mark Rowe (bdash) 2011-04-15 17:44:48 PDT
Comment 4 Adam Barth 2011-04-15 17:50:59 PDT
Comment 5 Mark Rowe (bdash) 2011-04-15 17:52:37 PDT
Comment 6 Timothy Hatcher 2011-04-15 17:55:43 PDT
Comment 7 Timothy Hatcher 2011-04-15 17:58:39 PDT
The build does not fail like I thought it did only because the All target does not build the wtftests target. If it did, it would fail because the gtest project can't be found.
Comment 8 David Levin 2011-04-15 18:00:03 PDT
I'm working on rolling this out.
Comment 9 Adam Barth 2011-04-15 18:12:04 PDT