Bug 58716
| Summary: | JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Critical | CC: | abarth, dslomov, eric, levin, lforschler, mrowe, timothy, webkit.review.bot |
| Priority: | P1 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.6 | ||
Timothy Hatcher
In https://trac.webkit.org/changeset/83974 JavaScriptCore became dependant on an external project. This breaks the build under Apple's internal build system.
In general anthing inside Source/JavaScriptCore (and WebCore, etc.) can't reference something outside that source root. So ../ThirdParty is a violation of that.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
The correct way to do this would be to build gtest and have JSC depend on it and link against it. Like WebCore does with ANGLE.
Timothy Hatcher
Mark Rowe has told me the build still works. But this is still not the normal way we do cross project dependancy in WebKit.
Mark Rowe (bdash)
I think this change should be reverted. JavaScriptCore.xcodeproj isn’t the right place for this to live. JavaScriptCore.xcodeproj should not depend on this random third-party library.
Adam Barth
Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built?
Mark Rowe (bdash)
(In reply to comment #4)
> Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built?
Does what mean that?
Timothy Hatcher
No, only the JavaScriptCore source tree exists when JavaScriptCore is built.
Timothy Hatcher
The build does not fail like I thought it did only because the All target does not build the wtftests target. If it did, it would fail because the gtest project can't be found.
David Levin
I'm working on rolling this out.
Adam Barth
> > Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built?
>
> Does what mean that?
I was trying to understand why this didn't break the build entirely. Comment #7 has the answer.
David Levin
Committed as http://trac.webkit.org/changeset/84068
WebKit Review Bot
http://trac.webkit.org/changeset/84068 might have broken Windows 7 Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-tree-model.html