Summary: | Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot* | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roland Steiner <rolandsteiner> | ||||||
Component: | Frames | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | buildbot, commit-queue, dglazkov, dominicc, jchaffraix, morrita, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 52788 | ||||||||
Bug Blocks: | 59802 | ||||||||
Attachments: |
|
Description
Roland Steiner
2011-04-15 15:27:27 PDT
Created attachment 91948 [details]
Patch
Attachment 91948 [details] did not build on qt: Build output: http://queues.webkit.org/results/8532285 Attachment 91948 [details] did not build on win: Build output: http://queues.webkit.org/results/8532302 Attachment 91948 [details] did not build on mac: Build output: http://queues.webkit.org/results/8529798 Comment on attachment 91948 [details]
Patch
I am impressed, but the bots aren't! :)
(In reply to comment #5) > (From update of attachment 91948 [details]) > I am impressed, but the bots aren't! :) I missed the WebKit2 directory (class InjectedBundleNodeHandle) which is making the bots sad. Patch forthcoming with this change! Created attachment 91983 [details]
Patch
Attachment 91948 [details] did not build on mac: Build output: http://queues.webkit.org/results/8536049 The commit-queue encountered the following flaky tests while processing attachment 91983 [details]: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 91983 [details] Patch Clearing flags on attachment: 91983 Committed r85644: <http://trac.webkit.org/changeset/85644> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 91983 [details]: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch. |