RESOLVED FIXED 58703
Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot* 
https://bugs.webkit.org/show_bug.cgi?id=58703
Summary Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
Roland Steiner
Reported Friday, April 15, 2011 11:27:27 PM UTC
Both functions currently return a ContainerNode*.
Attachments
Patch (14.56 KB, patch)
2011-05-02 11:47 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch (15.82 KB, patch)
2011-05-02 14:37 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 Monday, May 2, 2011 7:47:51 PM UTC
Created attachment 91948 [details] Patch
Early Warning System Bot
Comment 2 Monday, May 2, 2011 8:00:24 PM UTC
Attachment 91948 [details] did not build on qt: Build output: http://queues.webkit.org/results/8532285
Build Bot
Comment 3 Monday, May 2, 2011 9:19:29 PM UTC
Attachment 91948 [details] did not build on win: Build output: http://queues.webkit.org/results/8532302
WebKit Review Bot
Comment 4 Monday, May 2, 2011 10:20:00 PM UTC
Attachment 91948 [details] did not build on mac: Build output: http://queues.webkit.org/results/8529798
Dimitri Glazkov (Google)
Comment 5 Monday, May 2, 2011 10:25:35 PM UTC
Comment on attachment 91948 [details] Patch I am impressed, but the bots aren't! :)
Julien Chaffraix
Comment 6 Monday, May 2, 2011 10:29:25 PM UTC
(In reply to comment #5) > (From update of attachment 91948 [details]) > I am impressed, but the bots aren't! :) I missed the WebKit2 directory (class InjectedBundleNodeHandle) which is making the bots sad. Patch forthcoming with this change!
Julien Chaffraix
Comment 7 Monday, May 2, 2011 10:37:04 PM UTC
Created attachment 91983 [details] Patch
WebKit Review Bot
Comment 8 Monday, May 2, 2011 11:45:31 PM UTC
Attachment 91948 [details] did not build on mac: Build output: http://queues.webkit.org/results/8536049
WebKit Commit Bot
Comment 9 Tuesday, May 3, 2011 9:05:32 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 91983 [details]: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 Tuesday, May 3, 2011 9:08:36 PM UTC
Comment on attachment 91983 [details] Patch Clearing flags on attachment: 91983 Committed r85644: <http://trac.webkit.org/changeset/85644>
WebKit Commit Bot
Comment 11 Tuesday, May 3, 2011 9:08:42 PM UTC
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 12 Tuesday, May 3, 2011 11:10:05 PM UTC
The commit-queue encountered the following flaky tests while processing attachment 91983 [details]: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.