Bug 58703 - Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
Summary: Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on: 52788
Blocks: 59802
  Show dependency tree / graph
 
Reported: 2011-04-15 15:27 PDT by Roland Steiner
Modified: 2011-05-03 15:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.56 KB, patch)
2011-05-02 11:47 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Patch (15.82 KB, patch)
2011-05-02 14:37 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-04-15 15:27:27 PDT 
Both functions currently return a ContainerNode*.
Comment 1 Julien Chaffraix 2011-05-02 11:47:51 PDT 
Created attachment 91948 [details]
Patch
Comment 2 Early Warning System Bot 2011-05-02 12:00:24 PDT 
Attachment 91948 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8532285
Comment 3 Build Bot 2011-05-02 13:19:29 PDT 
Attachment 91948 [details] did not build on win:
Build output: http://queues.webkit.org/results/8532302
Comment 4 WebKit Review Bot 2011-05-02 14:20:00 PDT 
Attachment 91948 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8529798
Comment 5 Dimitri Glazkov (Google) 2011-05-02 14:25:35 PDT 
Comment on attachment 91948 [details]
Patch

I am impressed, but the bots aren't! :)
Comment 6 Julien Chaffraix 2011-05-02 14:29:25 PDT 
(In reply to comment #5)
> (From update of attachment 91948 [details])
> I am impressed, but the bots aren't! :)

I missed the WebKit2 directory (class InjectedBundleNodeHandle) which is making the bots sad. Patch forthcoming with this change!
Comment 7 Julien Chaffraix 2011-05-02 14:37:04 PDT 
Created attachment 91983 [details]
Patch
Comment 8 WebKit Review Bot 2011-05-02 15:45:31 PDT 
Attachment 91948 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8536049
Comment 9 WebKit Commit Bot 2011-05-03 13:05:32 PDT 
The commit-queue encountered the following flaky tests while processing attachment 91983 [details]:

animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2011-05-03 13:08:36 PDT 
Comment on attachment 91983 [details]
Patch

Clearing flags on attachment: 91983

Committed r85644: <http://trac.webkit.org/changeset/85644>
Comment 11 WebKit Commit Bot 2011-05-03 13:08:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 WebKit Commit Bot 2011-05-03 15:10:05 PDT 
The commit-queue encountered the following flaky tests while processing attachment 91983 [details]:

http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.