Bug 58693

Summary: REGRESSION: <progress> doesn't animate if it doesn't have value
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Description Hajime Morrita 2011-04-15 14:06:18 PDT 
The indefinite progress bar, which is rendered by <progress> element without value property should animate.
Looks introduced http://trac.webkit.org/changeset/83065.
Comment 1 Hajime Morrita 2011-04-15 15:07:16 PDT 
Created attachment 89862 [details]
Patch
Comment 2 Yael 2011-04-16 04:31:31 PDT 
Thanks for fixing it.
Comment 3 Adam Barth 2011-04-17 09:58:51 PDT 
Comment on attachment 89862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89862&action=review

Nice patch.  Yay for named constants.

> Source/WebCore/ChangeLog:12
> +        No new tests. Testing animated bar is not possible with DRT.

Frown.  This likely means we will continue to have regressions.
Comment 4 Kent Tamura 2011-04-17 19:09:22 PDT 
Comment on attachment 89862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89862&action=review

> Source/WebCore/html/HTMLProgressElement.cpp:43
> +const double HTMLProgressElement::IndeterminatePosition = -1;
> +const double HTMLProgressElement::InvalidPosition = -2;

In RenderProgress::isDeterminate(), we should use these named constants, or add a comment that "0 <= " means neither indeterminate nor invalid.
Comment 5 Hajime Morrita 2011-04-18 10:07:43 PDT 
Adam, Kent-san, thank you for reviewing!
I'll land this with addressing Kent-san's point.
Comment 6 Hajime Morrita 2011-04-18 10:14:16 PDT 
Committed r84156: <http://trac.webkit.org/changeset/84156>
Comment 7 WebKit Review Bot 2011-04-18 12:21:13 PDT 
http://trac.webkit.org/changeset/84156 might have broken GTK Linux 32-bit Debug