Summary: | new-run-webkit-tests: save stderr into the layout-test-results dir | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ojan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 58770 | ||||||
Bug Blocks: | 37739 | ||||||
Attachments: |
|
Description
Dirk Pranke
2011-04-15 13:49:55 PDT
Created attachment 89846 [details]
Patch
Splitting the saving of the error text out from the display of it (which I'll let Ojan fix in the original bug). Comment on attachment 89846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89846&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:341 > tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True) btw, typo: keybaord > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:348 > + 'stuff going to stderr') What makes the file contain "stuff going to stderr"? (In reply to comment #3) > (From update of attachment 89846 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89846&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:341 > > tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True) > > btw, typo: keybaord > Interesting. I'll fix that in a different bug. > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:348 > > + 'stuff going to stderr') > > What makes the file contain "stuff going to stderr"? That is done at port/test.py:147, which has custom logic to fake output going to stderr for that particular test. That code has been there forever. Comment on attachment 89846 [details]
Patch
Does this mean we're writing stderr into the test and into the stderr.txt? We should only be doing the latter. Fine with that being part of this patch or a separate patch though.
H(In reply to comment #5) > (From update of attachment 89846 [details]) > Does this mean we're writing stderr into the test and into the stderr.txt? We should only be doing the latter. Fine with that being part of this patch or a separate patch though. Hm. Good point, I had forgotten that the chromium ports were doing that. I'll fix that in a separate patch. Committed r84112: <http://trac.webkit.org/changeset/84112> grr. I don't know why I spaced and committed this yesterday w/o updating the baselines. This was rolled back in r84127 / bug 58690. double-grr: comment #8 applies to bug 58708, not this bug. This patch was fine and didn't need to be rolled out. |