Bug 58677

Summary: globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch to move globalObject() to JSObjectWithGlobalObject.h
none
Updated patch with bug reference in ChangeLog oliver: review+

Description Michael Saboff 2011-04-15 11:55:37 PDT
Created attachment 89824 [details]
Patch to move globalObject() to JSObjectWithGlobalObject.h

As part of r60057, globalObject() was moved from JSDOMBinding.h to JSObjectWithGlobalObject.cpp.  This limits a compilers ability to inline, especially in other components, namely WebCore.  This is causing a performance regression.

Moving globalObject() back to a .h file is worth ~5% on the dromaeo DOM benchmark.
Comment 1 WebKit Review Bot 2011-04-15 11:56:43 PDT
Attachment 89824 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Michael Saboff 2011-04-15 12:57:54 PDT
Created attachment 89835 [details]
Updated patch with bug reference in ChangeLog
Comment 3 Mark Rowe (bdash) 2011-04-15 13:09:20 PDT
Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog

“equivolent”
Comment 4 Oliver Hunt 2011-04-15 13:16:19 PDT
Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog

r=me
Comment 5 Jeff Miller 2011-04-15 13:47:42 PDT
Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=89835&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        it for a performance benefit.  An equivolent instance had been in

Typo - equivolent
Comment 6 Michael Saboff 2011-04-15 13:51:30 PDT
Committed r84030: <http://trac.webkit.org/changeset/84030>
Comment 7 Michael Saboff 2011-04-15 14:01:59 PDT
Note that I fixed the "equivalent" typo before landing the patch.
Comment 8 WebKit Review Bot 2011-04-15 18:20:29 PDT
http://trac.webkit.org/changeset/84030 might have broken WinCE Release (Build)