Summary: | globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Michael Saboff
2011-04-15 11:55:37 PDT
Attachment 89824 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 89835 [details]
Updated patch with bug reference in ChangeLog
Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog
“equivolent”
Comment on attachment 89835 [details]
Updated patch with bug reference in ChangeLog
r=me
Comment on attachment 89835 [details] Updated patch with bug reference in ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=89835&action=review > Source/JavaScriptCore/ChangeLog:10 > + it for a performance benefit. An equivolent instance had been in Typo - equivolent Committed r84030: <http://trac.webkit.org/changeset/84030> Note that I fixed the "equivalent" typo before landing the patch. http://trac.webkit.org/changeset/84030 might have broken WinCE Release (Build) |