Bug 58674

Summary: JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
[PATCH] Proposed Fix ddkilzer: review+

Joseph Pecoraro
Reported 2011-04-15 10:53:00 PDT
Possible JavaScript Allocation in the toJS call so we should take the JSLock beforehand: ScriptValue InjectedScriptHost::nodeAsScriptValue(ScriptState* state, Node* node) { return ScriptValue(state->globalData(), toJS(state, node)); } Path to follow.
Attachments
[PATCH] Proposed Fix (1.37 KB, patch)
2011-04-15 12:34 PDT, Joseph Pecoraro 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-04-15 12:34:06 PDT
Created attachment 89829 [details] [PATCH] Proposed Fix
David Kilzer (:ddkilzer)
Comment 2 2011-04-15 12:39:16 PDT
Comment on attachment 89829 [details] [PATCH] Proposed Fix r=me
Joseph Pecoraro
Comment 3 2011-04-15 13:02:25 PDT
<http://trac.webkit.org/changeset/84022>
Note You need to log in before you can comment on or make changes to this bug.