| Summary: | hide unused static function when SKIA_GPU is enabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Reed <reed> | ||||
| Component: | New Bugs | Assignee: | Mike Reed <reed> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, darin, eric, kbr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Mike Reed
2011-04-15 10:12:52 PDT
Created attachment 89801 [details]
Patch
This local function is not referenced when SKIA_GPU is enabled, and so we get a warning (which we treat as an error). This is just to address that warning: there is no functional change. Comment on attachment 89801 [details] Patch Rejecting attachment 89801 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8459206 This actually landed as http://trac.webkit.org/changeset/84000 , but the update of the bug failed. Closing it manually. http://trac.webkit.org/changeset/84000 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-82-t.svg |