| Summary: | [GTK] editing/selection/select-out-of-editable.html failing after r83967 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
| Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | mrobinson | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sergio Villar Senin
2011-04-15 08:38:53 PDT
Committed r83979: <http://trac.webkit.org/changeset/83979> The issue here seems to be that triggering another mouseDown event while the mouse button is already down can interfere with drags in Xvfb. Created attachment 90406 [details]
Patch
Comment on attachment 90406 [details]
Patch
We need to check that the button we are getting now is the same one that was already pressed.
Created attachment 91249 [details]
Updated patch with improved ChangeLog
(In reply to comment #4) > (From update of attachment 90406 [details]) > We need to check that the button we are getting now is the same one that was already pressed. Thanks for the review. I've updated the patch to allow consecutive mouse down events from different buttons and verified that it passes Daniel's test for this issue.(In reply to comment #0) > The diff: > > --- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt 2011-04-15 07:06:09.978467441 -0700 > +++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt 2011-04-15 07:06:09.959742392 -0700 > @@ -1,4 +1,4 @@ > hello world > -Dragging to the left: PASS > -Dragging to the left: PASS > +Dragging to the left: FAIL - expected 0 but got 7 > +Dragging to the left: FAIL - expected 11 but got 10 > > I'll skip it for the moment. Comment on attachment 91249 [details] Updated patch with improved ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=91249&action=review > Tools/DumpRenderTree/gtk/EventSender.cpp:65 > +static unsigned int buttonCurrentlyDown; unsigned is all you need, not "int". Comment on attachment 91249 [details] Updated patch with improved ChangeLog Clearing flags on attachment: 91249 Committed r85481: <http://trac.webkit.org/changeset/85481> All reviewed patches have been landed. Closing bug. |