Bug 58655

Summary: IndexedDB objectStoreNames not updated after aborted transaction
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, fishd, hans, jsbell, pilgrim, tony, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
test case
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2011-04-15 06:31:22 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_setVersion_abort.html?force=1 At the end of the test, the transaction is aborted and the object store should be removed (db.objectStoreNames.length should be 0). Mozilla correctly handles this, but WebKit still claims that objectStoreNames.length=1 and that objectStoreNames.item(0) is the name of the object store created during the now-aborted transaction.
Attachments
test case (2.07 KB, text/html)
2011-04-15 06:32 PDT, Mark Pilgrim (Google) 		no flags
Details
Patch (4.33 KB, patch)
2011-11-23 15:02 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (4.25 KB, patch)
2011-11-23 15:07 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-04-15 06:32:00 PDT
Created attachment 89775 [details] test case
Joshua Bell
Comment 2 2011-11-23 15:02:19 PST
Created attachment 116433 [details] Patch
Joshua Bell
Comment 3 2011-11-23 15:02:58 PST
This is already functional, but we didn't have a specific test. Adding the mozilla test c/o pilgrim@
David Grogan
Comment 4 2011-11-23 15:04:08 PST
Comment on attachment 116433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116433&action=review > LayoutTests/storage/indexeddb/mozilla/versionchange-abort.html:10 > +<link rel="stylesheet" href="../../../fast/js/resources/js-test-style.css"> We're not supposed to include this stylesheet anymore.
Joshua Bell
Comment 5 2011-11-23 15:07:07 PST
Created attachment 116435 [details] Patch
Joshua Bell
Comment 6 2011-11-23 15:10:39 PST
Comment on attachment 116435 [details] Patch removed stylesheet link
Joshua Bell
Comment 7 2011-12-07 10:40:06 PST
tony@ - r? cq?
WebKit Review Bot
Comment 8 2011-12-07 11:46:14 PST
Comment on attachment 116435 [details] Patch Clearing flags on attachment: 116435 Committed r102260: <http://trac.webkit.org/changeset/102260>
WebKit Review Bot
Comment 9 2011-12-07 11:46:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.