Bug 58642

Summary: CSP media-src is missing
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric.carlson, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 53572    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2011-04-15 00:23:33 PDT
CSP media-src is missing
Attachments
Patch (8.21 KB, patch)
2011-04-15 01:09 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.80 KB, patch)
2011-04-15 14:24 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-15 01:09:25 PDT
Created attachment 89755 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-15 06:37:12 PDT
Comment on attachment 89755 [details] Patch Hmm. Seems OK. why the stall in the tests?
Eric Carlson
Comment 3 2011-04-15 07:53:19 PDT
Comment on attachment 89755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89755&action=review Is CSP supposed to work with local files as well? If so, we should have equivalent tests in LayoutTests/media. > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:2 > +END OF TEST > + Because it isn't possible to have an explicit "PASS" in the results, it would be nice to have some text to indicate what the constitutes success. I hate having to look at a test's source to figure out if it succeeded or failed.
Adam Barth
Comment 4 2011-04-15 11:00:36 PDT
> Hmm. Seems OK. why the stall in the tests? It just comes from the test I copied. I can try removing the stall. I don't think it slows the test down in either case. > Is CSP supposed to work with local files as well? If so, we should have equivalent tests in LayoutTests/media. CSP can work with local files, yes. I've only been testing it for the HTTP case, but I can add a local test if you like. > > LayoutTests/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:2 > > +END OF TEST > > + > > Because it isn't possible to have an explicit "PASS" in the results, it would be nice to have some text to indicate what the constitutes success. I hate having to look at a test's source to figure out if it succeeded or failed. Will do.
Eric Carlson
Comment 5 2011-04-15 11:08:31 PDT
(In reply to comment #4) > > Hmm. Seems OK. why the stall in the tests? > > It just comes from the test I copied. I can try removing the stall. I don't think it slows the test down in either case. > It doesn't do anything in this case because the test ends when 'loadedmetadata' is fired.
Adam Barth
Comment 6 2011-04-15 14:24:43 PDT
Created attachment 89852 [details] Patch for landing
Adam Barth
Comment 7 2011-04-15 14:25:33 PDT
The test fails if I remove the "stall" URL parameter. Presumably there's a way to get rid of it, but it's not hurting anyone, so I've left it.
WebKit Commit Bot
Comment 8 2011-04-15 21:24:21 PDT
Comment on attachment 89852 [details] Patch for landing Clearing flags on attachment: 89852 Committed r84077: <http://trac.webkit.org/changeset/84077>
WebKit Commit Bot
Comment 9 2011-04-15 21:24:25 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2011-04-15 22:33:26 PDT
http://trac.webkit.org/changeset/84077 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.