Summary: | Make mac WebKit1 use the default localization strategy | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2011-04-14 20:26:24 PDT
Created attachment 89725 [details]
Patch
Comment on attachment 89725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89725&action=review r=me but see the comments about comments. > Source/WebCore/English.lproj/Localizable.strings:13 > -/* window title for a standalone image (uses multiplication symbol, not x) */ > +/* window title suffix for a standalone image (uses multiplication symbol, not x) */ It's not a suffix, it's a format string, so this comment change is not an improvement IMO. > Source/WebCore/English.lproj/Localizable.strings:16 > -/* window title for a standalone image (uses multiplication symbol, not x) */ > +/* window title suffix for a standalone image (uses multiplication symbol, not x) */ It's not a suffix, it's a format string, so this comment change is not an improvement IMO. Committed r83985: <http://trac.webkit.org/changeset/83985> |