Bug 58628

Summary: Make mac WebKit1 use the default localization strategy
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mjs: review+

Description Sam Weinig 2011-04-14 20:26:24 PDT
Make mac WebKit1 use the default localization strategy
Comment 1 Sam Weinig 2011-04-14 20:29:26 PDT
Created attachment 89725 [details]
Patch
Comment 2 Maciej Stachowiak 2011-04-15 01:21:31 PDT
Comment on attachment 89725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89725&action=review

r=me but see the  comments about comments.

> Source/WebCore/English.lproj/Localizable.strings:13
> -/* window title for a standalone image (uses multiplication symbol, not x) */
> +/* window title suffix for a standalone image (uses multiplication symbol, not x) */

It's not a suffix, it's a format string, so this comment change is not an improvement IMO.

> Source/WebCore/English.lproj/Localizable.strings:16
> -/* window title for a standalone image (uses multiplication symbol, not x) */
> +/* window title suffix for a standalone image (uses multiplication symbol, not x) */

It's not a suffix, it's a format string, so this comment change is not an improvement IMO.
Comment 3 Sam Weinig 2011-04-15 09:57:47 PDT
Committed r83985: <http://trac.webkit.org/changeset/83985>