Bug 58621

Summary: Update webglcontextlost / webglcontextrestored delivery to match spec changes
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: amarinichev, cmarrin, jamesr, senorblanco, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+

Kenneth Russell
Reported 2011-04-14 18:19:28 PDT
Based on feedback from Glenn Maynard, the WebGL spec was just updated to avoid side-effects of registering event handlers. Now, in order for webglcontextrestored to be delivered to the application, the developer must have registered a webglcontextlost handler, and that handler needs to call preventDefault() against the event object. WebKit's WebGL implementation needs to be updated to track this change, and ideally layout tests written using the WEBKIT_lose_context extension either created or updated.
Attachments
Patch (6.41 KB, patch)
2011-07-20 22:02 PDT, Kenneth Russell 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2011-07-20 22:02:36 PDT
Created attachment 101556 [details] Patch
James Robinson
Comment 2 2011-07-21 13:39:44 PDT
Comment on attachment 101556 [details] Patch OK
Kenneth Russell
Comment 3 2011-07-21 14:43:19 PDT
Committed r91504: <http://trac.webkit.org/changeset/91504>
Note You need to log in before you can comment on or make changes to this bug.