Bug 58596

Summary: WK2: Past searches not remembered for <input type=search results="5" autosave="foo">
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 mitz: review+, beidson: commit-queue-

Brady Eidson
Reported 2011-04-14 16:02:37 PDT
Past searches not remembered for <input type=search results="5"> in WebKit2. In radar as <rdar://problem/9287880>
Attachments
Patch v1 (8.84 KB, patch)
2011-04-15 10:49 PDT, Brady Eidson 		mitz: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2011-04-15 10:49:18 PDT
Created attachment 89810 [details] Patch v1
mitz
Comment 2 2011-04-15 12:11:34 PDT
Comment on attachment 89810 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=89810&action=review > Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:191 > + // The WebProcess shouldnt have bothered to send this message if the name was empty. Typo: shouldnt. > Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:197 > + size_t size = searchItems.size(); > + if (size) { size can be defined inside the if(). > Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:211 > + // The WebProcess shouldnt have bothered to send this message if the name was empty. Same typo!!
Brady Eidson
Comment 3 2011-04-15 12:25:34 PDT
r84011
Note You need to log in before you can comment on or make changes to this bug.