Summary: | Implement a cross-platform version of ExecutableAllocator::intializePageSize() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> | ||||||||
Component: | Java | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED DUPLICATE | ||||||||||
Severity: | Normal | CC: | aroben, gustavo.noronha, gustavo, mrobinson, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac (Intel) | ||||||||||
OS: | Windows 2000 | ||||||||||
Attachments: |
|
Description
Fridrich Strba
2011-04-14 14:28:32 PDT
Created attachment 89648 [details]
Patch
How is this working on the Safari Windows port? We don't use ExecutableAllocatorFixedVMPool.cpp on Windows, apparently. (In reply to comment #3) > We don't use ExecutableAllocatorFixedVMPool.cpp on Windows, apparently. So, it should not hurt anybody to get this in then :) Comment on attachment 89648 [details]
Patch
A better solution would be to replace the call to getpagesize with WTF::pageSize() which does the right thing for every platform.
Created attachment 92341 [details]
Patch
Comment on attachment 92341 [details]
Patch
Using WTF::pageSize() as per review comment.
Attachment 92341 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8571356 Created attachment 93417 [details]
Patch
Since now the EWS is showing no breakages, can this one get a positive review and commit queue approval? Ping someone? Comment on attachment 93417 [details] Patch Cleared review? from attachment 93417 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |