Bug 58572

Summary: Implement a cross-platform version of ExecutableAllocator::intializePageSize()
Product: WebKit Reporter: Fridrich Strba <fridrich.strba>
Component: JavaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aroben, gustavo.noronha, gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: Windows 2000   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Fridrich Strba 2011-04-14 14:28:32 PDT
Get page size on windows using win32 api
Comment 1 Fridrich Strba 2011-04-14 14:31:54 PDT
Created attachment 89648 [details]
Patch
Comment 2 Martin Robinson 2011-04-14 15:35:22 PDT
How is this working on the Safari Windows port?
Comment 3 Adam Roben (:aroben) 2011-04-15 06:19:57 PDT
We don't use ExecutableAllocatorFixedVMPool.cpp on Windows, apparently.
Comment 4 Fridrich Strba 2011-04-15 06:31:31 PDT
(In reply to comment #3)
> We don't use ExecutableAllocatorFixedVMPool.cpp on Windows, apparently.

So, it should not hurt anybody to get this in then :)
Comment 5 Oliver Hunt 2011-04-15 15:43:15 PDT
Comment on attachment 89648 [details]
Patch

A better solution would be to replace the call to getpagesize with WTF::pageSize() which does the right thing for every platform.
Comment 6 Fridrich Strba 2011-05-04 16:15:44 PDT
Created attachment 92341 [details]
Patch
Comment 7 Fridrich Strba 2011-05-04 16:16:47 PDT
Comment on attachment 92341 [details]
Patch

Using WTF::pageSize() as per review comment.
Comment 8 Collabora GTK+ EWS bot 2011-05-05 01:29:15 PDT
Attachment 92341 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8571356
Comment 9 Fridrich Strba 2011-05-13 01:56:45 PDT
Created attachment 93417 [details]
Patch
Comment 10 Fridrich Strba 2011-05-13 02:21:41 PDT
Since now the EWS is showing no breakages, can this one get a positive review and commit queue approval?
Comment 11 Fridrich Strba 2011-05-26 12:57:32 PDT
Ping someone?
Comment 12 Adam Roben (:aroben) 2011-05-26 13:03:35 PDT
Looks like this was fixed in r87198.

*** This bug has been marked as a duplicate of bug 61384 ***
Comment 13 Eric Seidel (no email) 2011-06-02 08:26:57 PDT
Comment on attachment 93417 [details]
Patch

Cleared review? from attachment 93417 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).