Bug 58570

Summary: Make creating WebPreferences lazy
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2011-04-14 14:27:55 PDT
Make creating WebPreferences lazy
Comment 1 Sam Weinig 2011-04-14 14:29:04 PDT
Created attachment 89647 [details]
Patch
Comment 2 Anders Carlsson 2011-04-14 14:34:15 PDT
Comment on attachment 89647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89647&action=review

> Source/WebKit2/ChangeLog:14
> +        Don't create the WebPrefernece object until it is requested.

Typo

> Source/WebKit2/UIProcess/WebPageGroup.cpp:101
> +        m_preferences->addPageGroup(this);

We don't need to call preferencesDidChange() here?
Comment 3 Sam Weinig 2011-04-14 14:39:30 PDT
Landed in r83895.