Summary: | [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jarkko Sakkinen <jarkko.j.sakkinen> | ||||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ademar, benjamin, commit-queue, jarkko.j.sakkinen | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Jarkko Sakkinen
2011-04-14 11:13:21 PDT
I'm preparing a fix for this. Created attachment 89740 [details]
layout test diff
The layout test has now 100% pass rate but the diff is different (see the attachment).
Created attachment 92576 [details]
Load image data when it is unloaded.
Created attachment 92578 [details]
Fixed line formatting for packPixels (now everything is in single source code line):
Comment on attachment 92578 [details]
Fixed line formatting for packPixels (now everything is in single source code line):
should this be up for review?
Yes. Forgot to update attachment flags :) Created attachment 92736 [details]
reinterpret_cast
Comment on attachment 92736 [details] reinterpret_cast Clearing flags on attachment: 92736 Committed r86026: <http://trac.webkit.org/changeset/86026> All reviewed patches have been landed. Closing bug. Revision r86026 cherry-picked into qtwebkit-2.2 with commit 9226105 <http://gitorious.org/webkit/qtwebkit/commit/9226105> |