Bug 58544

Summary: Don't emit RegExp tables for chromium where they are not used
Product: WebKit Reporter: Satish Sampath <satish>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andersca: review+

Satish Sampath
Reported 2011-04-14 08:01:34 PDT
The character tables generated by the create_regex_tables script are used only by the Yarr (Yet another regex runtime) JIT feature. Since the chromium port does not use the Yarr JIT feature, we don't need these tables in the generated code.
Attachments
Patch (2.76 KB, patch)
2011-04-14 08:03 PDT, Satish Sampath 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2011-04-14 08:03:30 PDT
Created attachment 89583 [details] Patch
Anders Carlsson
Comment 2 2011-04-14 08:16:57 PDT
Comment on attachment 89583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89583&action=review > Source/JavaScriptCore/create_regex_tables:38 > +emitTables = (len(sys.argv) < 2 or sys.argv[1] != "--notables") Could we call this --no-tables instead?
Satish Sampath
Comment 3 2011-04-14 08:48:00 PDT
Committed r83860: <http://trac.webkit.org/changeset/83860>
Note You need to log in before you can comment on or make changes to this bug.