Bug 58518

Summary:

BlobBuilder should be vendor-prefixed

Product:

WebKit

Reporter:

Kinuko Yasuda <kinuko>

Component:

WebCore Misc.

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ericu, fishd, tzik

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed Patch	fishd: review+, jianli: commit-queue-

Kinuko Yasuda

Reported 2011-04-13 23:28:33 PDT

Since FileWriter API is not yet standard, we should vendor-prefix BlobBuilder. (As for FileWriter it cannot be created without requesting FileSystem, whose entry point will be prefixed as well, we won't need to prefix it separately.) window.BlobBuilder -> window.webkitBlobBuilder

Attachments
Proposed Patch (70.47 KB, patch) 2011-04-14 13:01 PDT, Jian Li	fishd: review+ jianli: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2011-04-14 08:59:14 PDT

Shouldn't it be WebKitBlobBuilder, like WebKitPoint? Things you can construct start with an upper-case letter, right?

Jian Li

Comment 2 2011-04-14 13:01:27 PDT

Created attachment 89631 [details] Proposed Patch

Kinuko Yasuda

Comment 3 2011-04-17 22:45:17 PDT

Submitted: http://trac.webkit.org/changeset/83884

Note You need to log in before you can comment on or make changes to this bug.