Bug 58510

Summary:

webkit-patch upload failed on new binary files

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, dbates, simon.fraser, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
PrettyPatch output	none

Simon Fraser (smfr)

Reported 2011-04-13 21:42:08 PDT

Doing a 'webkit-patch upload' on some local (staged) changes in my git repo that included new PNG files failed with: Exception raised during decoding git binary patch: can't convert nil into String /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `pack' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `initialize' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `collect' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:538:in `initialize' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `new' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `parse' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `collect' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:603:in `parse' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:16:in `prettify' /Volumes/Monster/Development/apple/webkit/WebKit.git/Websites/bugs.webkit.org/PrettyPatch/prettify.rb:26

Attachments
PrettyPatch output (287.94 KB, text/plain) 2011-04-13 21:42 PDT, Simon Fraser (smfr)	no flags	Details
View All Add attachment proposed patch, testcase, etc.