Bug 58501

Summary:

Use HTMLImageElement in Canvas 2D / WebGL before response is ready causes crash

Product:

WebKit

Reporter:

Zhenyao Mo <zmo>

Component:

Canvas

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, darin, gman, kbr, mdelaney7, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	kbr: review+

Description Zhenyao Mo 2011-04-13 18:38:35 PDT

This is because cachedImage()->response().url().string().impl() is null, and hash(null) is not expected, thus crash.

Comment 1 Zhenyao Mo 2011-04-13 18:39:19 PDT

I am working on a fix for WebGL.  If someone else more familiar with canvas 2d could fix this on the canvas 2d side, it would be great!

Comment 2 Zhenyao Mo 2011-04-13 18:42:42 PDT

A test case for WebGL: 

svn checkout https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl
-r 14468

sdk/tests/conformance/tex-image-and-sub-image-2d-with-image.html

Current behavior: crash

correct behavior: no crash

Comment 3 Zhenyao Mo 2011-04-14 18:53:06 PDT

Created attachment 89716 [details]
Patch

Comment 4 Zhenyao Mo 2011-04-14 18:54:49 PDT

This patch makes sure WebGL won't process an HTMLImageElement if it's not ready yet.

mdelaney is getting another patch ready for the rest.

Comment 5 Kenneth Russell 2011-04-15 10:33:05 PDT

Comment on attachment 89716 [details]
Patch

Looks good.

Comment 6 Zhenyao Mo 2011-04-15 11:02:12 PDT

Committed r83992: <http://trac.webkit.org/changeset/83992>