Bug 58489

Summary:

[NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT

Product:

WebKit

Reporter:

Mihai Parparita <mihaip>

Component:

Tools / Tests

Assignee:

Mihai Parparita <mihaip>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, dpranke, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	eric: review+

Description Mihai Parparita 2011-04-13 15:30:28 PDT

[NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT

Comment 1 Mihai Parparita 2011-04-13 15:32:32 PDT

Created attachment 89480 [details]
Patch

Comment 2 Dirk Pranke 2011-04-13 15:39:25 PDT

Comment on attachment 89480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89480&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:257
> +        # Multiple additional paltform directories

Nit: typo "paltform"

Comment 3 Dirk Pranke 2011-04-13 15:39:38 PDT

Looks fine otherwise.

Comment 4 Mihai Parparita 2011-04-13 15:57:00 PDT

Created attachment 89484 [details]
Patch

Comment 5 Mihai Parparita 2011-04-13 15:57:14 PDT

(In reply to comment #2)
> Nit: typo "paltform"

Fixed.

Comment 6 Eric Seidel (no email) 2011-04-13 16:01:41 PDT

Comment on attachment 89484 [details]
Patch

OK.  How many chromium bots will this break? :)

Comment 7 Mihai Parparita 2011-04-13 16:02:16 PDT

(In reply to comment #6)
> (From update of attachment 89484 [details])
> OK.  How many chromium bots will this break? :)

0, since no bots use it yet :)

Comment 8 Mihai Parparita 2011-04-13 16:04:14 PDT

Committed r83783: <http://trac.webkit.org/changeset/83783>