Bug 58489

Summary: [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dpranke, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Mihai Parparita
Reported 2011-04-13 15:30:28 PDT
[NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
Attachments
Patch (7.39 KB, patch)
2011-04-13 15:32 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch (7.39 KB, patch)
2011-04-13 15:57 PDT, Mihai Parparita 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2011-04-13 15:32:32 PDT
Created attachment 89480 [details] Patch
Dirk Pranke
Comment 2 2011-04-13 15:39:25 PDT
Comment on attachment 89480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89480&action=review > Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:257 > + # Multiple additional paltform directories Nit: typo "paltform"
Dirk Pranke
Comment 3 2011-04-13 15:39:38 PDT
Looks fine otherwise.
Mihai Parparita
Comment 4 2011-04-13 15:57:00 PDT
Created attachment 89484 [details] Patch
Mihai Parparita
Comment 5 2011-04-13 15:57:14 PDT
(In reply to comment #2) > Nit: typo "paltform" Fixed.
Eric Seidel (no email)
Comment 6 2011-04-13 16:01:41 PDT
Comment on attachment 89484 [details] Patch OK. How many chromium bots will this break? :)
Mihai Parparita
Comment 7 2011-04-13 16:02:16 PDT
(In reply to comment #6) > (From update of attachment 89484 [details]) > OK. How many chromium bots will this break? :) 0, since no bots use it yet :)
Mihai Parparita
Comment 8 2011-04-13 16:04:14 PDT
Committed r83783: <http://trac.webkit.org/changeset/83783>
Note You need to log in before you can comment on or make changes to this bug.