Summary: | childTypeAllowed() should be const | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roland Steiner <rolandsteiner> | ||||
Component: | DOM | Assignee: | Roland Steiner <rolandsteiner> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | commit-queue, dglazkov, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Roland Steiner
2011-04-13 11:32:18 PDT
Incidentally, I wonder why this method, as well as nodeName() and nodeType() are private within all subclasses of Node... Created attachment 89415 [details]
Patch
(In reply to comment #1) > Incidentally, I wonder why this method, as well as nodeName() and nodeType() are private within all subclasses of Node... making a virtual impl private is a great trick for preventing the users of the function call them directly. It's also a great visual indication, saying "DON'T USE THIS METHOD DIRECTLY." Comment on attachment 89415 [details] Patch Clearing flags on attachment: 89415 Committed r83816: <http://trac.webkit.org/changeset/83816> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 89415 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. |