Bug 58457

Summary: Some borders with border-radius do not have rounded inner edges
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, bdakin, dglazkov, eric, peter, phiw2, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase
none
Screenshot: Firefox (left) vs. WebKit (right)
none
Screenshot: Firefox (left) vs. WebKit (right)
none
Patch
none
Patch bdakin: review+

Description Simon Fraser (smfr) 2011-04-13 10:58:20 PDT
Created attachment 89401 [details]
Testcase

See attached testcase and screenshot; WebKit does a really poor job of rendering some rounded borders.
Comment 1 Simon Fraser (smfr) 2011-04-13 10:58:52 PDT
Created attachment 89402 [details]
Screenshot: Firefox (left) vs. WebKit (right)
Comment 2 Simon Fraser (smfr) 2011-04-13 13:51:04 PDT
Created attachment 89449 [details]
Screenshot: Firefox (left) vs. WebKit (right)

In previous screenshot, WebKit was patched.
Comment 3 Simon Fraser (smfr) 2011-04-13 21:42:55 PDT
Created attachment 89529 [details]
Patch
Comment 4 WebKit Review Bot 2011-04-13 22:08:23 PDT
Attachment 89529 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8401569
Comment 5 Simon Fraser (smfr) 2011-04-13 22:23:40 PDT
Comment on attachment 89529 [details]
Patch

Will fix cr-linux
Comment 6 Simon Fraser (smfr) 2011-04-13 22:25:09 PDT
Created attachment 89532 [details]
Patch
Comment 7 Beth Dakin 2011-04-14 12:46:45 PDT
Comment on attachment 89532 [details]
Patch

I feel like this code could use more comments. r=me.
Comment 8 WebKit Review Bot 2011-04-15 18:19:13 PDT
http://trac.webkit.org/changeset/83998 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-82-t.svg
Comment 9 Simon Fraser (smfr) 2011-04-17 09:44:00 PDT
http://trac.webkit.org/changeset/83998