| Summary: | ORWT needs a way to look in a user-specified directory for platform-specific results | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dpranke, mihaip, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2011-04-13 08:59:58 PDT
Created attachment 89383 [details]
Patch
CCing Dirk since he is working on NRWT/ORWT parity. Committed r83743: <http://trac.webkit.org/changeset/83743> Heh, we actually added this to NRWT in r82972, except that we called it --baseline-search-path. It would be good if we actually used the same parameter name. I don't have a strong leaning either way, but I might like --additional-platform-directory a bit more. Mihai, what do you think? Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree. (In reply to comment #5) > Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree. The directory does not have to be within LayoutTests/platform. (In reply to comment #6) > The directory does not have to be within LayoutTests/platform. OK, will rename --baseline-search-path then. |