Bug 58427

Summary: [CMAKE] Separate DerivedSources.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, paroga, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 2000   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2011-04-13 02:58:36 PDT
Other ports build generated sources for different components in different directories but CMake doesn't.
Attachments
Patch (28.69 KB, patch)
2011-04-13 03:09 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-04-13 03:00:22 PDT
I did this change already on my box when building the apple win32 port with windows. If you have not done this already I can generate y patch and upload it here.
Ryuan Choi
Comment 2 2011-04-13 03:09:42 PDT
Created attachment 89359 [details] Patch
Ryuan Choi
Comment 3 2011-04-13 03:12:33 PDT
(In reply to comment #1) > I did this change already on my box when building the apple win32 port with windows. > If you have not done this already I can generate y patch and upload it here. Sorry, I didn't see your message. I checked on EFL port. but you can mark as a duplicated if you did.
Patrick R. Gansterer
Comment 4 2011-04-13 03:20:17 PDT
(In reply to comment #3) > (In reply to comment #1) > > I did this change already on my box when building the apple win32 port with windows. > > If you have not done this already I can generate y patch and upload it here. > > Sorry, I didn't see your message. > I checked on EFL port. but you can mark as a duplicated if you did. I only did it locally, so you can't know of it. ;-) Patch LGTM.
Lucas De Marchi
Comment 5 2011-04-13 07:56:17 PDT
LGTM too. Kenneth, can you rubber stamp it?
WebKit Commit Bot
Comment 6 2011-04-13 17:44:56 PDT
Comment on attachment 89359 [details] Patch Clearing flags on attachment: 89359 Committed r83792: <http://trac.webkit.org/changeset/83792>
WebKit Commit Bot
Comment 7 2011-04-13 17:45:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.