Bug 58423

Summary:

Web Inspector: [REGRESSION] diffs in resource revisions are not displayed.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch.	pfeldman: review+

Pavel Feldman

Reported 2011-04-13 02:26:57 PDT

Try editing css file live, save it multiple times. No clue on what has changed.

Attachments
Patch. (3.18 KB, patch) 2011-04-13 04:30 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-04-13 04:30:27 PDT

Created attachment 89365 [details] Patch.

Pavel Feldman

Comment 2 2011-04-13 04:32:06 PDT

Comment on attachment 89365 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89365&action=review > Source/WebCore/inspector/front-end/ResourceView.js:202 > + callback("Stylesheet not found."); Should you return empty content instead?

Pavel Podivilov

Comment 3 2011-04-13 04:34:42 PDT

(In reply to comment #2) > (From update of attachment 89365 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89365&action=review > > > Source/WebCore/inspector/front-end/ResourceView.js:202 > > + callback("Stylesheet not found."); > > Should you return empty content instead? This callback doesn't return content, it just notifies TextViewer whether new text was committed or rejected.

Pavel Podivilov

Comment 4 2011-04-13 04:39:15 PDT

Committed r83719: <http://trac.webkit.org/changeset/83719>

Note You need to log in before you can comment on or make changes to this bug.