| Summary: | [REGRESSION] A::before content not clickable | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||||||||
| Severity: | Normal | CC: | apavlov, ap, bweinstein, dglazkov, hyatt, joepeck, keishi, kulanthaivel, loislo, luctiemessen, mitz, mrobinson, myakura.web, pfeldman, pmuellr, rik, webkit.review.bot, yurys | ||||||||||||||
| Priority: | P1 | Keywords: | InRadar | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Pavel Feldman
2011-04-13 02:26:06 PDT
This is a regression from http://trac.webkit.org/changeset/83075 Created attachment 89374 [details]
[HTML] Reduced test case
Mouse events on A::before content should be handled the same way as on the A content. As a regression, it should be P1. *** Bug 60543 has been marked as a duplicate of this bug. *** Created attachment 94539 [details]
Proposed Patch.
Created attachment 94667 [details]
Proposed Patch.
Missed out a layout test image resource in my previous patch.
Comment on attachment 94667 [details] Proposed Patch. Attachment 94667 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8727694 New failing tests: fast/css/before-after-pseudo-element-selector-empty-anchor.html Created attachment 94689 [details]
Archive of layout-test-results from ec2-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 94722 [details]
Proposed Patch.
Fixed the expected test result.
Comment on attachment 94722 [details]
Proposed Patch.
I don't think this should be necessary. If you don't have a node you should just be moving up the line box tree to parents (and/or the RenderObject tree to parents). You shouldn't need a special bit just to identify generated content.
Created attachment 95007 [details]
Proposed Patch V2.
@reviewers: ping. This bug breaks a few bits of Web Inspector... There is another report on this issue: http://code.google.com/p/chromium/issues/detail?id=84256 This time, error circle next to the error count in console is not clickable (it is also implemented as ::before). @reviewers: anyone? Comment on attachment 95007 [details]
Proposed Patch V2.
This isn't quite right. You want something narrower. I suspect you could move the code from addNodeToRectBasedTestResult to updateHitTestResult to fix this bug.
Chromium issue: http://code.google.com/p/chromium/issues/detail?id=82888 Is this bug still under development? I am pretty new to this bug filing stuff but it seems the previous comment is referring to a chromium bug report that seems to be fixed but I am still getting this bug. The Chromium bugfix is a workaround of this issue, so this one is still valid and is waiting for someone to fix it. *** This bug has been marked as a duplicate of bug 91723 *** |