| Summary: | Make PropertyMapEntry use a WriteBarrier for specificValue | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Other | ||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Oliver Hunt
2011-04-12 18:33:10 PDT
Created attachment 89323 [details]
Patch
Attachment 89323 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1
Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 89323 [details] did not build on win: Build output: http://queues.webkit.org/results/8398116 Created attachment 89334 [details]
Patch
Attachment 89334 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1
Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 89334 [details] did not build on win: Build output: http://queues.webkit.org/results/8400185 Created attachment 89342 [details]
Patch
Attachment 89342 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1
Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 89342 [details] did not build on win: Build output: http://queues.webkit.org/results/8400229 Attachment 89342 [details] did not build on win: Build output: http://queues.webkit.org/results/8403160 Created attachment 89381 [details]
Patch
Attachment 89381 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1
Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 89381 [details] did not build on win: Build output: http://queues.webkit.org/results/8403268 Created attachment 89394 [details]
Patch
Attachment 89394 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1
Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 89394 [details]
Patch
Might be worth adding a comment re the PropertyTable code being non- write barrier correct.
Committed r83751: <http://trac.webkit.org/changeset/83751> |