Bug 58407

Summary: Make PropertyMapEntry use a WriteBarrier for specificValue
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch barraclough: review+

Oliver Hunt
Reported 2011-04-12 18:33:10 PDT
Make PropertyMapEntry use a WriteBarrier for specificValue
Attachments
Patch (75.38 KB, patch)
2011-04-12 18:35 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (77.58 KB, patch)
2011-04-12 21:21 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (78.23 KB, patch)
2011-04-12 22:50 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (79.22 KB, patch)
2011-04-13 08:34 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (80.03 KB, patch)
2011-04-13 10:09 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-04-12 18:35:02 PDT
Created attachment 89323 [details] Patch
WebKit Review Bot
Comment 2 2011-04-12 18:38:10 PDT
Attachment 89323 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1 Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2011-04-12 19:53:16 PDT
Attachment 89323 [details] did not build on win: Build output: http://queues.webkit.org/results/8398116
Oliver Hunt
Comment 4 2011-04-12 21:21:06 PDT
Created attachment 89334 [details] Patch
WebKit Review Bot
Comment 5 2011-04-12 21:23:12 PDT
Attachment 89334 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1 Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 6 2011-04-12 21:49:23 PDT
Attachment 89334 [details] did not build on win: Build output: http://queues.webkit.org/results/8400185
Oliver Hunt
Comment 7 2011-04-12 22:50:14 PDT
Created attachment 89342 [details] Patch
WebKit Review Bot
Comment 8 2011-04-12 22:53:07 PDT
Attachment 89342 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1 Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 9 2011-04-12 23:58:03 PDT
Attachment 89342 [details] did not build on win: Build output: http://queues.webkit.org/results/8400229
Build Bot
Comment 10 2011-04-13 00:27:32 PDT
Attachment 89342 [details] did not build on win: Build output: http://queues.webkit.org/results/8403160
Oliver Hunt
Comment 11 2011-04-13 08:34:36 PDT
Created attachment 89381 [details] Patch
WebKit Review Bot
Comment 12 2011-04-13 08:37:23 PDT
Attachment 89381 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1 Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 13 2011-04-13 09:42:41 PDT
Attachment 89381 [details] did not build on win: Build output: http://queues.webkit.org/results/8403268
Oliver Hunt
Comment 14 2011-04-13 10:09:11 PDT
Created attachment 89394 [details] Patch
WebKit Review Bot
Comment 15 2011-04-13 10:11:25 PDT
Attachment 89394 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp',..." exit_code: 1 Source/JavaScriptCore/runtime/Structure.h:146: The parameter name "mode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 16 2011-04-13 11:34:38 PDT
Comment on attachment 89394 [details] Patch Might be worth adding a comment re the PropertyTable code being non- write barrier correct.
Oliver Hunt
Comment 17 2011-04-13 11:53:19 PDT
Committed r83751: <http://trac.webkit.org/changeset/83751>
Note You need to log in before you can comment on or make changes to this bug.