| Summary: | Rename onEndChain and make it a static method. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yael <yael> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Yael
2011-04-12 17:28:34 PDT
Thanks. Created attachment 89316 [details]
Patch.
Comment on attachment 89316 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > Source/WebCore/rendering/InlineFlowBox.cpp:255 > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) Should mark it static and possibly inline. (In reply to comment #3) > (From update of attachment 89316 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review > > Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > > > Source/WebCore/rendering/InlineFlowBox.cpp:255 > > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) > > Should mark it static and possibly inline. Terribly sorry, I forgot to mark it static. Thanks for catching it. I'll mark it inline if the compiler agrees :) Committed r83679: <http://trac.webkit.org/changeset/83679> |