Bug 58403

Summary: Rename onEndChain and make it a static method.
Product: WebKit Reporter: Yael <yael>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch. eric: review+, eric: commit-queue-

Yael
Reported 2011-04-12 17:28:34 PDT
The method onEndChain should be renamed and should become static.
Attachments
Patch. (3.33 KB, patch)
2011-04-12 17:34 PDT, Yael 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-04-12 17:28:54 PDT
Thanks.
Yael
Comment 2 2011-04-12 17:34:41 PDT
Created attachment 89316 [details] Patch.
Eric Seidel (no email)
Comment 3 2011-04-12 17:46:28 PDT
Comment on attachment 89316 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > Source/WebCore/rendering/InlineFlowBox.cpp:255 > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) Should mark it static and possibly inline.
Yael
Comment 4 2011-04-12 17:54:42 PDT
(In reply to comment #3) > (From update of attachment 89316 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review > > Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > > > Source/WebCore/rendering/InlineFlowBox.cpp:255 > > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) > > Should mark it static and possibly inline. Terribly sorry, I forgot to mark it static. Thanks for catching it. I'll mark it inline if the compiler agrees :)
Yael
Comment 5 2011-04-12 18:37:32 PDT
Committed r83679: <http://trac.webkit.org/changeset/83679>
Note You need to log in before you can comment on or make changes to this bug.