| Summary: | Web Inspector: Timeline is too narrow | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Annie Sullivan <sullivan> | ||||||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
That reminds me. We never added the "collapse the shaded columns button" that was agreed upon when this issue was brought up in the beginning. Created attachment 89676 [details]
Patch
Comment on attachment 89676 [details] Patch This patch needs a ChangeLog entry, according to http://www.webkit.org/coding/contributing.html Created attachment 89681 [details]
New patch, fixes changelog
We still should add a colapse button. Yes, we should still add a button to collapse shaded columns. Filed bug 58602 for that. Created attachment 89693 [details]
Screenshot of network panel before patch
Created attachment 89694 [details]
Screenshot of Network Panel after patch
I couldn't figure out how to make tooltips display while I was taking a screenshot, but if you hover the mouse over a narrower column, you get a tooltip with the column text.
Comment on attachment 89681 [details] New patch, fixes changelog View in context: https://bugs.webkit.org/attachment.cgi?id=89681&action=review This looks good, thanks for doing it. > Source/WebCore/ChangeLog:5 > + Changed Network Panel widths so that Timeline is 50%. It should be: WebInspector: Title http://... <optional blank line> Multiline description here. Changes digest. > Source/WebCore/inspector/front-end/NetworkPanel.js:960 > + widths.timeline = 50; It leaves 5% left, is that intentional? Did you check whether column resize bars are aligned properly? > Source/WebCore/inspector/front-end/NetworkPanel.js:1436 > + _setTextAndTitle: function(element, text) You could define setTextAndTitle on Elements' prototype in the utilities.js. Comment on attachment 89681 [details] New patch, fixes changelog View in context: https://bugs.webkit.org/attachment.cgi?id=89681&action=review >> Source/WebCore/ChangeLog:5 >> + Changed Network Panel widths so that Timeline is 50%. > > It should be: > > WebInspector: Title > http://... > <optional blank line> > Multiline description here. > > Changes digest. Done. >> Source/WebCore/inspector/front-end/NetworkPanel.js:960 >> + widths.timeline = 50; > > It leaves 5% left, is that intentional? Did you check whether column resize bars are aligned properly? Oops, miscounted the number of columns. Changed so it sums correctly to 100%. Column resize bars are aligned properly, at least after the change. >> Source/WebCore/inspector/front-end/NetworkPanel.js:1436 >> + _setTextAndTitle: function(element, text) > > You could define setTextAndTitle on Elements' prototype in the utilities.js. Done. Created attachment 89837 [details]
New patch, addresses review comments
Comment on attachment 89837 [details] New patch, addresses review comments Clearing flags on attachment: 89837 Committed r84614: <http://trac.webkit.org/changeset/84614> All reviewed patches have been landed. Closing bug. |
Created attachment 89312 [details] Firebug vs Web Inspector Net panel widths The timeline column in the network pane is only 30% of the width, making it a bit hard to read. It should be wider, like Firebug (which appears to be 50%).