Bug 58392

Summary: WebKit2: Frames prevent scrolling containing page
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Sam Weinig 2011-04-12 16:18:08 PDT
WebKit2: Frames prevent scrolling containing page
Comment 1 Sam Weinig 2011-04-12 16:26:25 PDT
Created attachment 89302 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-04-12 17:07:35 PDT
Comment on attachment 89302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89302&action=review

> Source/WebCore/page/FrameView.cpp:144
> +            if (m_page->mainFrame() == m_frame) {

This test feels backwards.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:792
> +    if (fabsf(wheelEvent.deltaY()) >= fabsf(wheelEvent.deltaX())) {

Add a FIXME to fix this?
Comment 3 Sam Weinig 2011-04-12 17:20:16 PDT
Committed r83672: <http://trac.webkit.org/changeset/83672>