Bug 58390

Summary: Implement remaining Background and Mask css properties in CSSStyleApplyProperty
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, macpherson, simon.fraser, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Luke Macpherson
Reported 2011-04-12 16:06:08 PDT
Implement remaining Background and Mask css properties in CSSStyleApplyProperty
Attachments
Patch (18.40 KB, patch)
2011-04-12 16:08 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (18.24 KB, patch)
2011-04-12 17:06 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-04-12 16:08:01 PDT
Created attachment 89298 [details] Patch
Luke Macpherson
Comment 2 2011-04-12 17:06:13 PDT
Created attachment 89309 [details] Patch
WebKit Commit Bot
Comment 3 2011-04-12 22:13:00 PDT
Comment on attachment 89309 [details] Patch Clearing flags on attachment: 89309 Committed r83700: <http://trac.webkit.org/changeset/83700>
WebKit Commit Bot
Comment 4 2011-04-12 22:13:07 PDT
All reviewed patches have been landed. Closing bug.
Andrey Kosyakov
Comment 5 2011-04-13 07:51:17 PDT
Comment on attachment 89309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89309&action=review > Source/WebCore/css/CSSStyleApplyProperty.cpp:78 > + virtual void applyValue(CSSStyleSelector*, CSSValue*) This broke chromium clang build due to missing const method modifier (causes shadowing base class method instead of overriding). Fixed in r83731.
Luke Macpherson
Comment 6 2011-04-13 17:12:48 PDT
(In reply to comment #5) > (From update of attachment 89309 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89309&action=review > > > Source/WebCore/css/CSSStyleApplyProperty.cpp:78 > > + virtual void applyValue(CSSStyleSelector*, CSSValue*) > > This broke chromium clang build due to missing const method modifier (causes shadowing base class method instead of overriding). Fixed in r83731. Well spotted. Thanks for the fix Andrey.
Note You need to log in before you can comment on or make changes to this bug.