| Summary: | Allow WebView users to recreate dependent contexts after a context lost | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Labour <piman> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | amarinichev, commit-queue, kbr, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antoine Labour
2011-04-12 15:50:44 PDT
Created attachment 89288 [details]
Patch
Attachment 89288 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 89291 [details]
Patch
Comment on attachment 89291 [details]
Patch
This looks good to me. Alexey, do you have any comments?
Looks good to me. My only comment is a general consistency, not related to this patch in particular. All other classes with graphicsContext3D method (WebGLRenderingContext, DrawingBuffer, SharedGraphicsContext3D) do not have any side-effects. It might end up being confusing. Comment on attachment 89291 [details]
Patch
r=me
Comment on attachment 89291 [details] Patch Clearing flags on attachment: 89291 Committed r83693: <http://trac.webkit.org/changeset/83693> All reviewed patches have been landed. Closing bug. |