Bug 58371

Summary: [chromium] Fix spelling layout tests since virtual function changed
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: New BugsAssignee: John Abd-El-Malek <jam>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

John Abd-El-Malek
Reported 2011-04-12 13:37:01 PDT
[chromium] Fix spelling layout tests since virtual function changed
Attachments
Patch (1.58 KB, patch)
2011-04-12 13:37 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2011-04-12 15:49 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2011-04-12 13:37:23 PDT
Created attachment 89264 [details] Patch
Jian Li
Comment 2 2011-04-12 13:40:03 PDT
Please also update ChangeLog.
Eric Seidel (no email)
Comment 3 2011-04-12 13:45:07 PDT
ChangeLog fail. also, strange commit message. :( And failed to close the bug. :( webkit-patch will do this all for you. But I can understand that our tools can be confusing to those not familiar with them.
John Abd-El-Malek
Comment 4 2011-04-12 13:50:06 PDT
(In reply to comment #3) > ChangeLog fail. > > also, strange commit message. :( > > And failed to close the bug. :( > > webkit-patch will do this all for you. But I can understand that our tools can be confusing to those not familiar with them. sorry, I was in a hurry to fix the build. I thought it's ok to commit manually for tree fixes? I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there.
Eric Seidel (no email)
Comment 5 2011-04-12 13:52:48 PDT
(In reply to comment #4) > (In reply to comment #3) > > ChangeLog fail. > > > > also, strange commit message. :( > > > > And failed to close the bug. :( > > > > webkit-patch will do this all for you. But I can understand that our tools can be confusing to those not familiar with them. > > sorry, I was in a hurry to fix the build. I thought it's ok to commit manually for tree fixes? > > I think I was confused because I ran webkit-patch in Tools/DumpRenderTree/chromium, and it didn't find a ChangeLog there. Understandable. And yes, its certainly acceptable to commit build fixes w/o much process. We still generally have ChangeLogs for them. Seems like you got bit by Chromium's DRT missing a ChangeLog. Thanks for the quick fix.
John Abd-El-Malek
Comment 6 2011-04-12 15:49:23 PDT
Created attachment 89287 [details] Patch
John Abd-El-Malek
Comment 7 2011-04-12 15:50:30 PDT
please ignore the latest patch, that was uploaded here by accident
Eric Seidel (no email)
Comment 8 2011-04-12 16:31:50 PDT
Comment on attachment 89287 [details] Patch I'm sorry our tools have caused you so much trouble. There is a bug about webkit-patch needing to warn people when uploading to closed patches.
Note You need to log in before you can comment on or make changes to this bug.