Bug 58340

Summary:

Web Inspector: another pass of protocol renames.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Description Pavel Feldman 2011-04-12 10:10:23 PDT

Debugger, Network and DOM events look reasonable to me after this change.

Comment 1 Pavel Feldman 2011-04-12 23:56:40 PDT

Created attachment 89345 [details]
Patch

Comment 2 Yury Semikhatsky 2011-04-13 00:02:52 PDT

Comment on attachment 89345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89345&action=review

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:56
> +        injectedScript.evaluate(errorString, expression, objectGroup ? *objectGroup : "", includeCommandLineAPI ? *includeCommandLineAPI : false, result);

Conversions like objectGroup ? *objectGroup : "" can well be made in generated dispatcher code, that would simplify agents code a bit.

Comment 3 Pavel Feldman 2011-04-13 00:04:37 PDT

Committed r83706: <http://trac.webkit.org/changeset/83706>