| Summary: | Web Inspector: ResourceView.createResourceView should return ResourceView instance. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Podivilov
2011-04-12 08:51:33 PDT
Created attachment 89209 [details]
Patch.
Comment on attachment 89209 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89209&action=review > Source/WebCore/inspector/front-end/ResourceView.js:61 > + this._sourceFrame.show(parentElement); Why do we need the show / hide logic in the SourceFrame now? Can we use the same view in the scripts panel instead? > Source/WebCore/inspector/front-end/SourceFrame.js:42 > + this._view = new WebInspector.View(); Why do you need this? I thought we agreed that there should be no SourceFrame -> View dependency. |