Bug 58324

Summary: Web Inspector: remove scriptWorldType from the protocol.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[PATCH] that compiles. yurys: review+

Pavel Feldman
Reported 2011-04-12 08:28:32 PDT
Patch to follow.
Attachments
Patch (14.45 KB, patch)
2011-04-12 08:50 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] that compiles. (15.43 KB, patch)
2011-04-12 09:14 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-04-12 08:50:49 PDT
Created attachment 89208 [details] Patch
Early Warning System Bot
Comment 2 2011-04-12 09:02:51 PDT
Attachment 89208 [details] did not build on qt: Build output: http://queues.webkit.org/results/8391424
Pavel Feldman
Comment 3 2011-04-12 09:14:55 PDT
Created attachment 89212 [details] [PATCH] that compiles.
Build Bot
Comment 4 2011-04-12 09:32:56 PDT
Attachment 89208 [details] did not build on win: Build output: http://queues.webkit.org/results/8395096
Yury Semikhatsky
Comment 5 2011-04-12 10:01:17 PDT
Comment on attachment 89212 [details] [PATCH] that compiles. View in context: https://bugs.webkit.org/attachment.cgi?id=89212&action=review > Source/WebCore/bindings/js/ScriptDebugServer.cpp:247 > + return true; return (currentWorld(exec) != mainThreadNormalWorld()); ? > Source/WebCore/bindings/v8/DebuggerScript.js:80 > + isContentScript: script.context_data && script.context_data.indexOf("injected") == 0 Please cast the expression to boolean explicitly to avoid surprises when it's an undefined and is casted ToBoolean() in ScriptDebugServer.cpp.
Pavel Feldman
Comment 6 2011-04-12 10:07:50 PDT
Committed r83601: <http://trac.webkit.org/changeset/83601>
Note You need to log in before you can comment on or make changes to this bug.