Bug 58322

Summary: Web Inspector: Web Page Performance auditing fails
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested fix
none
[PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look) pfeldman: review+

Alexander Pavlov (apavlov)
Reported 2011-04-12 08:18:37 PDT
1. Navigate to cnn.com and open inspector 2. Go to Audits tab and click on Run What is the expected output? Auditing should finish and load the data What do you see instead? Auditing doesn't finish. If Web Page Performance is disabled, auditing is completed. Auditing on google.com and yahoo.com works fine though. Upstreaming Chromium issue http://code.google.com/p/chromium/issues/detail?id=78473
Attachments
[PATCH] Suggested fix (10.89 KB, patch)
2011-04-12 08:48 PDT, Alexander Pavlov (apavlov)
no flags
[PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look) (12.22 KB, patch)
2011-04-12 10:49 PDT, Alexander Pavlov (apavlov)
pfeldman: review+
Alexander Pavlov (apavlov)
Comment 1 2011-04-12 08:48:46 PDT
Created attachment 89207 [details] [PATCH] Suggested fix
Alexander Pavlov (apavlov)
Comment 2 2011-04-12 10:49:38 PDT
Created attachment 89227 [details] [PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look)
Pavel Feldman
Comment 3 2011-04-13 02:00:58 PDT
Comment on attachment 89227 [details] [PATCH] DOMAgent.requestDocument() fixed (for pfeldman to have a look) View in context: https://bugs.webkit.org/attachment.cgi?id=89227&action=review > Source/WebCore/inspector/front-end/AuditRules.js:362 > + WebInspector.domAgent.querySelector(document.id, selectors[i], queryCallback.bind(null, i === selectors.length - 1 ? selectorsCallback.bind(null, callback, styleSheets, testedSelectors) : null, selectors[i], styleSheets, testedSelectors)); You should requestDocument within DOMAgent.js::querySelector instead. I thought Andrey has fixed it already - he had a patch pending. Also I can't parse this string - you should extract variables for bound functions, etc.
Alexander Pavlov (apavlov)
Comment 4 2011-04-13 03:20:53 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/audits/audits-panel-functional.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/AuditRules.js Committed r83716
Note You need to log in before you can comment on or make changes to this bug.