Bug 58307

Summary: [GStreamer] some public callbacks remain
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch mrobinson: review+

Philippe Normand
Reported 2011-04-12 01:57:09 PDT
We should make those static in the cpp file: mediaPlayerPrivateMessageCallback mediaPlayerPrivateRepaintCallback mediaPlayerPrivateSourceChangedCallback
Attachments
proposed patch (19.63 KB, patch)
2011-04-12 03:02 PDT, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-04-12 03:02:20 PDT
Created attachment 89182 [details] proposed patch
Alexis Menard (darktears)
Comment 2 2011-04-12 05:46:03 PDT
Comment on attachment 89182 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=89182&action=review Otherwise the patch looks good for me. It makes the code easier to read. > Source/WebCore/ChangeLog:5 > + [GStreamer] some public callbacks remain Shouldn't you put a uper case letter after [GStreamer]
Martin Robinson
Comment 3 2011-04-12 07:30:53 PDT
Comment on attachment 89182 [details] proposed patch Nice cleanup.
Philippe Normand
Comment 4 2011-04-12 09:37:26 PDT
Committed r83598: <http://trac.webkit.org/changeset/83598>
Note You need to log in before you can comment on or make changes to this bug.