Bug 58285

Summary: CompositeAnimation is cleared while an AnimationBase is waiting for notification
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Dean Jackson
Reported 2011-04-11 16:33:44 PDT
<rdar://problem/9243181> <rdar://problem/9241918> <rdar://problem/9239320> From Apple crash reporter, multiple instances of the AnimationControllerPrivate sending out notifications to animations that no longer have a valid CompositeAnimation.
Attachments
Patch (6.08 KB, patch)
2011-04-11 16:55 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (6.03 KB, patch)
2011-04-11 17:01 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2011-04-11 16:55:09 PDT
Created attachment 89121 [details] Patch
WebKit Review Bot
Comment 2 2011-04-11 16:56:56 PDT
Attachment 89121 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/animation/AnimationBase.cpp:932: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/page/animation/AnimationBase.cpp:1205: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/page/animation/AnimationBase.cpp:1264: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/page/animation/AnimationBase.cpp:1378: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/page/animation/AnimationBase.cpp:1402: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 5 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 3 2011-04-11 17:01:00 PDT
Created attachment 89124 [details] Patch Must have passed wrong args to check-webkit-style :(
Simon Fraser (smfr)
Comment 4 2011-04-11 17:09:00 PDT
Comment on attachment 89124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89124&action=review > Source/WebCore/page/animation/AnimationBase.cpp:929 > + // Exit if we have no CompositeAnimation This and all the other same comments are not useful. The code says it.
Dean Jackson
Comment 5 2011-04-11 17:39:10 PDT
http://trac.webkit.org/changeset/83542
Note You need to log in before you can comment on or make changes to this bug.