Summary: | REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jberlin, jonlee, mjs | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Attachments: |
|
Description
Jon Lee
2011-04-11 16:20:24 PDT
Created attachment 89117 [details]
Patch
Comment on attachment 89117 [details]
Patch
Is it possible to create a regression test for this? If so, please add one, if not, r=me
I spoke with Enrica about this, and she told me that because the bug was in the menu and not keyboard shortcuts, that this is not something that can be tested via DumpRenderTree. Created attachment 89425 [details]
Patch
New patch that avoids the #ifdef PLATFORM() call and moves it to a runtime check in EditingBehavior.h
Comment on attachment 89425 [details]
Patch
r=me
The commit-queue encountered the following flaky tests while processing attachment 89425 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 89425 [details] Patch Clearing flags on attachment: 89425 Committed r83814: <http://trac.webkit.org/changeset/83814> All reviewed patches have been landed. Closing bug. *** Bug 58209 has been marked as a duplicate of this bug. *** |