Bug 58263

Summary: Use EncodedValueDescriptor on both JSVALUE32_64, JSVALUE64.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   

Gavin Barraclough
Reported 2011-04-11 13:29:25 PDT
The JSJITInterface already uses EncodedValueDescriptor to access the tag/payload separately on JSVALUE64, even though EncodedValueDescriptor is not used in JSVALUE64's implementation of JSValue. Remove the separate definition for m_ptr on X86_64. Using the union allows us to remove a layer of makeImmediate()/immedaiteValue() methods.
Attachments
Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-04-11 15:18:41 PDT
fixed in r83517
Note You need to log in before you can comment on or make changes to this bug.