Bug 58252

Summary: WebKit2: links don’t update to look visited
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2011-04-11 11:53:43 PDT
WebKit2: links don’t update to look visited
Comment 1 Sam Weinig 2011-04-11 12:00:24 PDT
Created attachment 89043 [details]
Patch
Comment 2 Anders Carlsson 2011-04-11 12:02:15 PDT
Comment on attachment 89043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89043&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:281
> +    for (size_t i = 0; i < linkHashes.size(); ++i) {
> +        HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it = m_pageGroupMap.begin();
> +        HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end = m_pageGroupMap.end();
> +        for (; it != end; ++it)
> +            Page::visitedStateChanged(PageGroup::pageGroup(it->second->identifier()), linkHashes[i]);
> +    }

Could you add a FIXME here specifying that we might not want to track visited links per context but per page group?

> Source/WebKit2/WebProcess/WebProcess.cpp:289
> -    Page::allVisitedStateChanged(sharedPageGroup());
> +    HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it = m_pageGroupMap.begin();
> +    HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end = m_pageGroupMap.end();
> +    for (; it != end; ++it)
> +        Page::allVisitedStateChanged(PageGroup::pageGroup(it->second->identifier()));

Ditto.
Comment 3 Sam Weinig 2011-04-11 12:13:45 PDT
Fixed in r83472.