Bug 58250

Summary: Rename MediaControls to MediaControlRootElement.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 53020    
Bug Blocks:    
Attachments:
Description Flags
Needs full bake on EWS. eric.carlson: review+, commit-queue: commit-queue-

Description Dimitri Glazkov (Google) 2011-04-11 11:43:00 PDT
Rename MediaControls to MediaControlRootElement.
Comment 1 Dimitri Glazkov (Google) 2011-04-11 11:44:57 PDT
Created attachment 89040 [details]
Needs full bake on EWS.
Comment 2 Eric Carlson 2011-04-11 11:55:42 PDT
Comment on attachment 89040 [details]
Needs full bake on EWS.

View in context: https://bugs.webkit.org/attachment.cgi?id=89040&action=review

> Tools/ChangeLog:9
> +2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Rename MediaControls to MediaControlRootElement.
> +        https://bugs.webkit.org/show_bug.cgi?id=58250
> +
> +        * Scripts/do-webcore-rename:
> +

Oops?

> Tools/Scripts/do-webcore-rename:100
> -    "DocLoader" => "CachedResourceLoader",
> +    "MediaControls" => "MediaControlRootElement",

Oops, did you really mean to check this in?
Comment 3 Dimitri Glazkov (Google) 2011-04-11 12:15:48 PDT
(In reply to comment #2)
> (From update of attachment 89040 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89040&action=review
> 
> > Tools/ChangeLog:9
> > +2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Rename MediaControls to MediaControlRootElement.
> > +        https://bugs.webkit.org/show_bug.cgi?id=58250
> > +
> > +        * Scripts/do-webcore-rename:
> > +
> 
> Oops?
> 
> > Tools/Scripts/do-webcore-rename:100
> > -    "DocLoader" => "CachedResourceLoader",
> > +    "MediaControls" => "MediaControlRootElement",
> 
> Oops, did you really mean to check this in?

I know it looks weird, but that's how we're supposed to do it. Each rename also commits the change here, so that you can easily see what's been renamed using this tool: http://trac.webkit.org/log/trunk/Tools/Scripts/do-webcore-rename
Comment 4 Eric Carlson 2011-04-11 12:19:54 PDT
(In reply to comment #3)
> I know it looks weird, but that's how we're supposed to do it. Each rename also commits 
> the change here, so that you can easily see what's been renamed using this tool: 
> http://trac.webkit.org/log/trunk/Tools/Scripts/do-webcore-rename

Hah, I learned something new today.
Comment 5 WebKit Commit Bot 2011-04-11 17:04:55 PDT
Comment on attachment 89040 [details]
Needs full bake on EWS.

Rejecting attachment 89040 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
/WebCore/rendering/MediaControlElements.h
patching file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/public/WebContextMenuData.h
patching file Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/do-webcore-rename

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8392085
Comment 6 Dimitri Glazkov (Google) 2011-04-11 18:06:11 PDT
Committed r83545: <http://trac.webkit.org/changeset/83545>