Bug 58231

Summary: Web Inspector: fix source mapping for deobfuscated scripts.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, jberlin, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Added test.
none
Add test. pfeldman: review+

Pavel Podivilov
Reported 2011-04-11 06:21:45 PDT
Web Inspector: fix source mapping for deobfuscated scripts. Existing source mapping appears to be inaccurate in some cases. New regexp would have much more matches, thus providing more accurate mapping.
Attachments
Patch. (6.10 KB, patch)
2011-04-11 06:22 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Added test. (11.26 KB, patch)
2011-04-12 05:49 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Add test. (11.24 KB, patch)
2011-04-12 09:51 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-04-11 06:22:18 PDT
Created attachment 89000 [details] Patch.
Pavel Feldman
Comment 2 2011-04-11 22:04:58 PDT
Comment on attachment 89000 [details] Patch. Can this be tested?
Pavel Podivilov
Comment 3 2011-04-12 05:49:38 PDT
Created attachment 89190 [details] Added test.
Pavel Podivilov
Comment 4 2011-04-12 09:51:25 PDT
Created attachment 89220 [details] Add test.
Pavel Podivilov
Comment 5 2011-04-13 09:46:26 PDT
Committed r83748: <http://trac.webkit.org/changeset/83748>
Jessie Berlin
Comment 6 2011-04-13 15:17:36 PDT
(In reply to comment #5) > Committed r83748: <http://trac.webkit.org/changeset/83748> The new test broke on a bunch of platforms (definitely all the Apple ones).
Note You need to log in before you can comment on or make changes to this bug.